-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 8 support - bring guzzle adapter in house #2547
Laravel 8 support - bring guzzle adapter in house #2547
Conversation
Alrighty all tests run locally anyway. |
I think the reasons the tests are failing is due to the I would have thought moving it to be a dev dependency would have sorted but doesn't seem like it. 🤔 |
We're only using a model factory in one file: https://github.com/statamic/cms/blob/master/tests/Auth/Eloquent/EloquentUserTest.php#L101 We can probably just avoid using a model factory there and then get rid of the dependency. |
Having some difficulty w/ fake user generation and non-unique |
I have opened a PR on your fork which fixes all the failing tests by not using laravel/legacy-factories but instead using Faker on the failing test directly. |
Fix test running without legacy-factories package
You have merged my PR only "half". You use "WithFaker" Trait in the Test now without using Faker in the "makeUser" method. |
Thanks very much for this. 🎉 @mrmonat, too. |
The Guzzle Adapter package doesn't support Guzzle 7 via constraints but does work with no changes. License was MIT, so brought in house so we can support Laravel 8.
All tests pass.